mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] vmalloc might sleep
Date: Sun, 31 Aug 2003 04:06:43 +0100	[thread overview]
Message-ID: <20030831030643.GQ13467@parcelfarce.linux.theplanet.co.uk> (raw)


So let's whack people upside the head when they misuse it.

vmalloc-might-sleep.diff:

Index: mm/vmalloc.c
===================================================================
RCS file: /var/cvs/linux-2.6/mm/vmalloc.c,v
retrieving revision 1.2
diff -u -p -r1.2 vmalloc.c
--- a/mm/vmalloc.c	23 Aug 2003 02:47:26 -0000	1.2
+++ b/mm/vmalloc.c	31 Aug 2003 03:04:25 -0000
@@ -438,7 +438,8 @@ fail:
  */
 void *vmalloc(unsigned long size)
 {
-       return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM, PAGE_KERNEL);
+	might_sleep();
+	return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM, PAGE_KERNEL);
 }
 
 /**
@@ -451,6 +452,7 @@ void *vmalloc(unsigned long size)
  */
 void *vmalloc_32(unsigned long size)
 {
+	might_sleep();
 	return __vmalloc(size, GFP_KERNEL, PAGE_KERNEL);
 }
 

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

             reply	other threads:[~2003-08-31  3:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-31  3:06 Matthew Wilcox [this message]
2003-08-31  3:20 ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030831030643.GQ13467@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome