mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Poetzl <herbert@13thfloor.at>
To: linux-kernel@vger.kernel.org
Cc: Tigran Aivazian <tigran@veritas.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: dontdiff for 2.6.0-test4
Date: Mon, 1 Sep 2003 18:54:21 +0200	[thread overview]
Message-ID: <20030901165421.GA20603@DUK2.13thfloor.at> (raw)
In-Reply-To: <20030901162244.GA1041@mars.ravnborg.org>

On Mon, Sep 01, 2003 at 06:22:44PM +0200, Sam Ravnborg wrote:
> On Mon, Sep 01, 2003 at 04:39:58PM +0100, Christoph Hellwig wrote:
> > > I have updated dontdiff in the usual place:
> > >   http://www.moses.uklinux.net/patches/dontdiff
> > > /usr/src/linux/Documentation/SubmittingPatches
> > 
> > Btw, what about putting this somewhere in the kernel tree?
> 
> I do not like dontdiff to be part of the kernel tree.
> What is included in dontdiff is redundant information already known
> by kbuild. Effectively dontdiff should not list any files that would
> not be removed during a "make mrproper".

I have to agree, do not get me wrong, dontdiff might be very
useful, although I personally do not use it to create kernel
patches, but IMHO it should be autogenerated not handcrafted

best,
Herbert

> Instead why not use the knowledge kbuild has and implement
> 'make dontdiff'
> 
> This could generate the list of files used for 'diff -X'.
> I can try to hack up something during the week just to see if
> it looks ok.
> 
> 	Sam
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2003-09-01 16:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-01 14:57 Tigran Aivazian
2003-09-01 15:39 ` Christoph Hellwig
2003-09-01 15:51   ` Tigran Aivazian
2003-09-01 16:12     ` Jeff Garzik
2003-09-01 16:09   ` Maciej Soltysiak
2003-09-01 16:15     ` Tigran Aivazian
2003-09-01 16:22   ` Sam Ravnborg
2003-09-01 16:54     ` Herbert Poetzl [this message]
2003-09-01 17:07     ` Jeff Garzik
2003-09-01 17:18       ` Sam Ravnborg
2003-09-01 21:47         ` Mike Fedyk
2003-09-01 22:29           ` Charles Lepple
2003-09-02  1:24         ` Jeff Garzik
2003-09-02  4:05           ` Sam Ravnborg
     [not found]         ` <fa.ebr1o03.l4o1q3@ifi.uio.no>
2003-09-02  2:36           ` Junio C Hamano
2003-09-02  2:47             ` Jeff Garzik
2003-09-02  5:55               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030901165421.GA20603@DUK2.13thfloor.at \
    --to=herbert@13thfloor.at \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tigran@veritas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®