From: Sam Ravnborg <sam@ravnborg.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
"Randy.Dunlap" <rddunlap@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ikconfig - resolve rebuild permissions
Date: Thu, 4 Sep 2003 21:13:53 +0200 [thread overview]
Message-ID: <20030904191353.GA10448@mars.ravnborg.org> (raw)
In-Reply-To: <20030904113133.3f950a51.shemminger@osdl.org>
On Thu, Sep 04, 2003 at 11:31:33AM -0700, Stephen Hemminger wrote:
> This patch fixes it by removing the configs.o file when
> needed.
A better approach would be to remove the need for compile.h from
configs.c. See attached patch for the makefile change.
It just took the relevant part from mk_compile and
used it in the Makefile.
Example only - I expect Randy to integrate it properly.
But what you see is also a more fundamental problem.
Should we allow the kernel to be build by two distinct users -
in this case a normal user and root.
We could check for this early, and stop. But it would require
too many changes in the top-level Makefile for my taste.
Sam
===== kernel/Makefile 1.33 vs edited =====
--- 1.33/kernel/Makefile Mon Sep 1 01:13:58 2003
+++ edited/kernel/Makefile Thu Sep 4 21:05:29 2003
@@ -19,6 +19,7 @@
obj-$(CONFIG_BSD_PROCESS_ACCT) += acct.o
obj-$(CONFIG_COMPAT) += compat.o
obj-$(CONFIG_IKCONFIG) += configs.o
+CFLAGS_configs.o = -DLINUX_COMPILER="$(shell $(CC) -v 2>&1 | tail -n 1)"
ifneq ($(CONFIG_IA64),y)
# According to Alan Modra <alan@linuxcare.com.au>, the -fno-omit-frame-pointer is
next prev parent reply other threads:[~2003-09-04 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-04 18:31 Stephen Hemminger
2003-09-04 19:13 ` Sam Ravnborg [this message]
2003-09-05 1:08 ` Randy.Dunlap
2003-09-05 1:22 ` Randy.Dunlap
2003-09-05 1:48 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030904191353.GA10448@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=shemminger@osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®