From: Pavel Machek <pavel@suse.cz>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, viro@math.psu.edu
Subject: Re: [BUG] mtime&ctime updated when it should not
Date: Sat, 6 Sep 2003 10:05:43 +0200 [thread overview]
Message-ID: <20030906080543.GA3944@openzaurus.ucw.cz> (raw)
In-Reply-To: <20030902130657.GB30594@atrey.karlin.mff.cuni.cz>
Hi!
> > > > Isn't this sufficient?
> > > I think it is not (I tried exactly the same patch but it didn't work)
> > > - the problem is that vmtruncate() is called when prepare_write() fails
> > > and this function also updates mtime and ctime.
> >
> > Oh OK.
> >
> > So we would need to change each filesystem's ->truncate to not update the
> > inode times, then move the timestamp updating up into vmtruncate().
> That is one solution. The other (less intrusive) is to just store old
> time stamps and restore times when you find out that write failed.
What if userspace sees the new time for a short while? That would certainly be
a bug...
Pavel
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
prev parent reply other threads:[~2003-09-08 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 18:11 Jan Kara
2003-09-01 18:35 ` Herbert Poetzl
2003-09-01 19:05 ` Jan Kara
2003-09-01 22:48 ` Mike Fedyk
2003-09-01 19:18 ` Andrew Morton
2003-09-01 19:31 ` Jan Kara
2003-09-01 19:58 ` Andrew Morton
2003-09-02 13:06 ` Jan Kara
2003-09-06 8:05 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030906080543.GA3944@openzaurus.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®