mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Anton Blanchard <anton@samba.org>
Cc: jeremy@goop.org, linux-kernel@vger.kernel.org,
	bos@serpentine.com, netdev@oss.sgi.com
Subject: Re: 2.6.0-test4-mm6: locking imbalance with rtnl_lock/unlock?
Date: Sat, 6 Sep 2003 18:47:15 -0700	[thread overview]
Message-ID: <20030906184715.38bf70d9.akpm@osdl.org> (raw)
In-Reply-To: <20030906222436.GB15327@krispykreme>

Anton Blanchard <anton@samba.org> wrote:
>
> 
> > which is SIOCGIFADDR.  It seems to me the down() is actually the
> > rtnl_lock() called at net/ipv4/devinet.c:536 in devinet_ioctl.  This
> > happens even when netplugd is no longer running.  It looks like someone
> > isn't releasing the lock.
> > 
> > I'm going over all the uses of rtnl_lock() to see if I can find a
> > problem, but no sign yet.  I wonder if someone might have broken this
> > recently: I'm running 2.6.0-test4-mm6, but I think Bryan is running an
> > older kernel (2.6.0-test4?), and hasn't seen any problems.
> 
> Yep I saw this too when updating from test2 to BK from a few days ago.
> >From memory the cpu that had the rtnl_lock was stuck in dev_close,
> probably netif_poll_disable. I got side tracked and wasnt able to look
> into it.

If the caller of netif_poll_disable() has a signal pending,
netif_poll_disable() becomes a busy loop, which might be causing a
lockup.  Probably not, but it needs to use TASK_UNINTERRUPTIBLE.

I doubt if that explains Jeremy's deadlock though...

      reply	other threads:[~2003-09-07  1:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-06 22:00 Jeremy Fitzhardinge
2003-09-06 22:24 ` Anton Blanchard
2003-09-07  1:47   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030906184715.38bf70d9.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=bos@serpentine.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®