From: Russell King <rmk@arm.linux.org.uk>
To: Zwane Mwaikambo <zwane@linuxpower.ca>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.6] arch/arm/mm/tlb-v4wb.S needs to lose a header
Date: Mon, 8 Sep 2003 08:47:06 +0100 [thread overview]
Message-ID: <20030908084706.C1092@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20030908084258.B1092@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Mon, Sep 08, 2003 at 08:42:58AM +0100
On Mon, Sep 08, 2003 at 08:42:58AM +0100, Russell King wrote:
> > In file included from include/asm/tlbflush.h:14,
> > from arch/arm/mm/tlb-v4wb.S:18:
> > include/linux/mm.h:87: warning: `VM_EXEC' redefined
> > include/asm/constants.h:16: warning: this is the location of the previous
> > definition
>
> This is caused by including linux/mm.h into asm/tlbflush.h, but it does
> show that we don't need asm/tlbflush.h included here.
Sorry, you do need asm/tlbflush.h here - we use the various tlb flag
definitions from there in the assembly files to avoid duplicating them.
The solution is not to include linux/mm.h in the first place.
--
Russell King (rmk@arm.linux.org.uk) http://www.arm.linux.org.uk/personal/
Linux kernel maintainer of:
2.6 ARM Linux - http://www.arm.linux.org.uk/
2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2003-09-08 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-08 4:40 Zwane Mwaikambo
2003-09-08 7:42 ` Russell King
2003-09-08 7:47 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908084706.C1092@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome