From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: fedor@karpelevitch.net, abz@frogfoot.net, linux-kernel@vger.kernel.org
Subject: Re: possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig)
Date: Mon, 8 Sep 2003 17:09:02 -0700 [thread overview]
Message-ID: <20030908170902.66f85c38.akpm@osdl.org> (raw)
In-Reply-To: <3F5D17EA.4010502@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Andrew Morton wrote:
> > diff -puN include/linux/netdevice.h~ifdown-lockup-fix include/linux/netdevice.h
> > --- 25/include/linux/netdevice.h~ifdown-lockup-fix Mon Sep 8 13:20:28 2003
> > +++ 25-akpm/include/linux/netdevice.h Mon Sep 8 13:20:34 2003
> > @@ -854,7 +854,7 @@ static inline void netif_rx_complete(str
> >
> > static inline void netif_poll_disable(struct net_device *dev)
> > {
> > - while (test_and_set_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> > + while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> > /* No hurry. */
> > current->state = TASK_INTERRUPTIBLE;
> > schedule_timeout(1);
> >
>
>
> no that breaks other things.
>
The only thing it can break is tg3, which appears to be placing a competing
interpretation upon the handling of this flag.
Given that tg3_netif_stop() will set __LINK_STATE_RX_SCHED and dev_close()
will then loop on it getting cleared again there appears to be a risk that
a dev_close() against tg3 will lock up.
It's all very unclear. And uncommented, but that is experientially the
same thing :(
next prev parent reply other threads:[~2003-09-09 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-04 18:05 BUG: 2.4.23-pre3 + ifconfig Abraham van der Merwe
[not found] ` <200309071217.03470.fedor@karpelevitch.net>
2003-09-07 19:15 ` Abraham van der Merwe
[not found] ` <200309080943.26254.fedor@karpelevitch.net>
2003-09-08 16:46 ` possibly bug in 8139cp? (WAS Re: BUG: 2.4.23-pre3 + ifconfig) Abraham van der Merwe
2003-09-08 17:26 ` Jeff Garzik
2003-09-08 20:32 ` Andrew Morton
2003-09-08 23:59 ` Jeff Garzik
2003-09-09 0:09 ` Andrew Morton [this message]
2003-09-09 0:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908170902.66f85c38.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=abz@frogfoot.net \
--cc=fedor@karpelevitch.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®