mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: mingo@redhat.com, drepper@redhat.com, roland@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use group_leader->pgrp (was Re: setpgid and threads)
Date: Mon, 8 Sep 2003 20:21:47 -0700	[thread overview]
Message-ID: <20030908202147.3cba2ecd.akpm@osdl.org> (raw)
In-Reply-To: <1063073637.4004.14.camel@localhost.localdomain>

Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
> On Mon, 2003-09-08 at 19:12, Andrew Morton wrote:
> > and to then rename task_struct.pgrp to something else, to pick up any
> > missed conversions?
> 
> Probably a good idea.

Caught a few:

drivers/char/tty_io.c: In function `tty_check_change':
drivers/char/tty_io.c:332: structure has no member named `pgrp'
drivers/char/tty_io.c:334: structure has no member named `pgrp'

	if (is_orphaned_pgrp(current->pgrp))
		return -EIO;
	(void) kill_pg(current->pgrp,SIGTTOU,1);

should these be converted?


drivers/char/tty_io.c: In function `tty_open':
drivers/char/tty_io.c:1409: structure has no member named `pgrp'

		tty->pgrp = current->pgrp;

this one?

drivers/char/tty_io.c: In function `tiocsctty':
drivers/char/tty_io.c:1583: structure has no member named `pgrp'

        tty->pgrp = current->pgrp;

and this.  I think so?

  reply	other threads:[~2003-09-09  3:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1061424262.24785.29.camel@localhost.localdomain>
     [not found] ` <20030820194940.6b949d9d.akpm@osdl.org>
2003-09-09  1:59   ` Jeremy Fitzhardinge
2003-09-09  2:12     ` Andrew Morton
2003-09-09  2:13       ` Jeremy Fitzhardinge
2003-09-09  3:21         ` Andrew Morton [this message]
2003-09-09  3:54           ` Ulrich Drepper
2003-09-09  4:17             ` Andrew Morton
2003-09-09  4:38               ` Ulrich Drepper
2003-09-09  5:56               ` Jeremy Fitzhardinge
2003-09-09  6:24       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030908202147.3cba2ecd.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®