From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: akpm@osdl.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pdc4030: return needs value; function needs return;
Date: Wed, 10 Sep 2003 03:14:26 +0200 [thread overview]
Message-ID: <200309100314.26305.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <20030909165414.2f0a5113.rddunlap@osdl.org>
Hi,
On Wednesday 10 of September 2003 01:54, Randy.Dunlap wrote:
> @@ -317,7 +317,7 @@ int __init ide_probe_for_pdc4030(void)
> #endif
> }
> }
> -#ifdef MODULE
> +#ifndef MODULE
> return 0;
> #endif
> }
This is wrong, we will now get warning for module instead of built-in.
Proper fix is to remove this #ifdef.
--bartlomiej
next prev parent reply other threads:[~2003-09-10 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 23:54 Randy.Dunlap
2003-09-10 1:14 ` Bartlomiej Zolnierkiewicz [this message]
2003-09-10 4:34 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200309100314.26305.bzolnier@elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®