From: Milton Miller <miltonm@bga.com>
To: Patrick Mochel <mochel@osdl.org>, Andi Kleen <ak@suse.de>,
Daniel Blueman <daniel.blueman@gmx.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [linux-2.4.0-test5] swsusp w/o swap fail...
Date: Fri, 12 Sep 2003 22:49:29 -0500 (CDT) [thread overview]
Message-ID: <200309130349.h8D3nTvG035109@sullivan.realtime.net> (raw)
In-Reply-To: <Pine.LNX.4.33.0309121509120.984-100000@localhost.localdomain>
To fix bugzilla 1131, Andi added select SOFTWARE_SUSPEND when ACPI_SLEEP
is selected. However, as discussed elsewhere [1], select superceedes
depends. Rather than say ACPI_SLEEP also enables SWAP, how about having
X86_64 pick up a change made to x86, and compile suspend.c on CONFIG_PM.
Andi, can you test this?
milton
[1] Re: [patch] 2.6.0-test5: serio config broken?
http://www.ussg.iu.edu/hypermail/linux/kernel/0309.1/1572.html
===== drivers/acpi/Kconfig 1.20 vs edited =====
--- 1.20/drivers/acpi/Kconfig Sat Aug 23 06:07:34 2003
+++ edited/drivers/acpi/Kconfig Fri Sep 12 22:28:08 2003
@@ -69,7 +69,6 @@
bool "Sleep States (EXPERIMENTAL)"
depends on X86 && ACPI
depends on EXPERIMENTAL && PM
- select SOFTWARE_SUSPEND
default y
---help---
This option adds support for ACPI suspend states.
===== arch/x86_64/kernel/Makefile 1.23 vs edited =====
--- 1.23/arch/x86_64/kernel/Makefile Mon Aug 18 13:16:59 2003
+++ edited/arch/x86_64/kernel/Makefile Fri Sep 12 22:28:56 2003
@@ -16,7 +16,8 @@
obj-$(CONFIG_SMP) += smp.o smpboot.o trampoline.o
obj-$(CONFIG_X86_LOCAL_APIC) += apic.o nmi.o
obj-$(CONFIG_X86_IO_APIC) += io_apic.o mpparse.o
-obj-$(CONFIG_SOFTWARE_SUSPEND) += suspend.o suspend_asm.o
+obj-$(CONFIG_PM) += suspend.o
+obj-$(CONFIG_SOFTWARE_SUSPEND) += suspend_asm.o
obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
obj-$(CONFIG_GART_IOMMU) += pci-gart.o aperture.o
obj-$(CONFIG_DUMMY_IOMMU) += pci-nommu.o pci-dma.o
next prev parent reply other threads:[~2003-09-13 3:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-11 22:09 Daniel Blueman
2003-09-12 22:11 ` Patrick Mochel
2003-09-12 22:29 ` Bernd Petrovitsch
2003-09-15 15:42 ` Patrick Mochel
2003-09-13 3:49 ` Milton Miller [this message]
2003-09-13 7:23 ` Andi Kleen
2003-09-14 9:32 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200309130349.h8D3nTvG035109@sullivan.realtime.net \
--to=miltonm@bga.com \
--cc=ak@suse.de \
--cc=daniel.blueman@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®