From: Jamie Lokier <jamie@shareable.org>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: rusty@rustcorp.com.au,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/futex.c: Uneeded memory barrier
Date: Sat, 13 Sep 2003 20:02:42 +0100 [thread overview]
Message-ID: <20030913190242.GC7404@mail.jlokier.co.uk> (raw)
In-Reply-To: <3F620E61.4080604@terra.com.br>
The patch looks fine to me.
Felipe W Damasio wrote:
> Kills an unneeded set_current_state after schedule_timeout, since it
> already guarantees that the task will be TASK_RUNNING.
>
> Also, when setting the state to TASK_RUNNING, isn't that memory
> barrier unneeded? Patch removes this memory barrier too.
If _all_ instances in the kernel of
set_current_state(TASK_RUNNING)
can be validly turned into
__set_current_state(TASK_RUNNING)
it would be good to make the barrier in set_current_state() itself
conditional on the state being state.
-- Jamie
next prev parent reply other threads:[~2003-09-13 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-12 18:20 Felipe W Damasio
2003-09-12 18:33 ` Felipe W Damasio
2003-09-15 9:39 ` Rusty Russell
2003-09-16 12:05 ` Jamie Lokier
2003-09-13 19:02 ` Jamie Lokier [this message]
2003-09-15 1:36 ` Rusty Russell
2003-09-14 11:39 ` Rusty Russell
2003-09-14 14:08 ` Jamie Lokier
2003-09-15 3:41 ` Rusty Russell
2003-09-15 9:23 ` Russell King
2003-09-15 16:32 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030913190242.GC7404@mail.jlokier.co.uk \
--to=jamie@shareable.org \
--cc=felipewd@terra.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®