mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: netpoll/netconsole minor tweaks
Date: Wed, 17 Sep 2003 11:24:47 -0700	[thread overview]
Message-ID: <20030917112447.A24623@osdlab.pdx.osdl.net> (raw)

Hi Matt,

Here's a couple small tweaks.  The first is to netpoll_setup.  The settle
time was too short for my e100, and the system would hang.  The second
is to netconsole so that it registers a console with CON_PRINTBUFFER.
This helps debugging early bootup issues where you want to capture data
from before netconsole is initialized.  Perhaps it should be a param
to netconsole?

thanks,
-chris

--- 2.6.0-test5-mm2/net/core/netpoll.c.wait_fix	2003-09-15 15:46:28.000000000 -0700
+++ 2.6.0-test5-mm2/net/core/netpoll.c	2003-09-15 16:14:20.000000000 -0700
@@ -526,7 +526,7 @@ int netpoll_setup(struct netpoll *np)
 		rtnl_shunlock();
 
 		/* Give driver a chance to settle */
-		jiff = jiffies + 2*HZ;
+		jiff = jiffies + 4*HZ;
 		while (time_before(jiffies, jiff))
 			;
 	}

--- 2.6.0-test5-mm2/drivers/net/netconsole.c.print_buf	2003-09-15 16:21:31.000000000 -0700
+++ 2.6.0-test5-mm2/drivers/net/netconsole.c	2003-09-17 11:09:59.000000000 -0700
@@ -95,7 +95,7 @@
 }
 
 static struct console netconsole = {
-	.flags = CON_ENABLED,
+	.flags = CON_ENABLED | CON_PRINTBUFFER,
 	.write = write_msg
 };

             reply	other threads:[~2003-09-17 18:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-17 18:24 Chris Wright [this message]
2003-09-17 20:51 ` Matt Mackall
2003-09-18  5:17   ` Chris Wright
2003-09-18 12:30 ` Alan Cox
2003-09-18 16:48   ` Chris Wright
2003-09-18 17:13     ` Arjan van de Ven
2003-09-18 17:50       ` Chris Wright
2003-09-18 21:12     ` Alan Cox
2003-09-18 23:10       ` Jesper Juhl
2003-09-19  7:40         ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030917112447.A24623@osdlab.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®