From: viro@parcelfarce.linux.theplanet.co.uk
To: Matthew Wilcox <willy@debian.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: What's the point of __KERNEL_SYSCALLS__?
Date: Sun, 21 Sep 2003 06:23:36 +0100 [thread overview]
Message-ID: <20030921052335.GE7665@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030921045411.GC13172@parcelfarce.linux.theplanet.co.uk>
> --- drivers/media/dvb/frontends/alps_tdlb7.c 29 Jul 2003 17:25:42 -0000 1.2
> +++ drivers/media/dvb/frontends/alps_tdlb7.c 21 Sep 2003 04:01:52 -0000
[snip]
> @@ -161,25 +158,25 @@ static int sp8870_read_code(const char *
> loff_t l;
> char *dp;
>
> - fd = open(fn, 0, 0);
> + fd = sys_open(fn, 0, 0);
*Ugh*
What context is it executed in? I'd tried to trace the potential callers,
but I don't see immediate reasons to believe that it never can happen in
user task context. It either should be shown (and commented) or we'd
better switch to filp_open() and friends. Descriptor tables can be shared...
next prev parent reply other threads:[~2003-09-21 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-19 16:40 Matthew Wilcox
2003-09-21 4:54 ` Matthew Wilcox
2003-09-21 5:23 ` viro [this message]
2003-09-21 8:11 ` Alan Cox
2003-09-22 17:23 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030921052335.GE7665@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®