mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: khc@pm.waw.pl, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95
Date: Mon, 22 Sep 2003 12:22:15 -0700	[thread overview]
Message-ID: <20030922122215.4f7da13e.akpm@osdl.org> (raw)
In-Reply-To: <20030922191049.GC6325@fs.tum.de>

Adrian Bunk <bunk@fs.tum.de> wrote:
>
> I'm getting the following compile error with gcc 2.95:
> 
> <--  snip  -->
> 
> ...
>   CC      drivers/net/wan/wanxl.o
> drivers/net/wan/wanxl.c: In function `pci_map_single_debug':
> drivers/net/wan/wanxl.c:128: warning: unsigned int format, different type arg (arg 3)
> drivers/net/wan/wanxl.c: In function `wanxl_tx_intr':
> drivers/net/wan/wanxl.c:185: parse error before `struct'


 25-akpm/drivers/net/wan/wanxl.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff -puN drivers/net/wan/wanxl.c~wanxl-build-fix drivers/net/wan/wanxl.c
--- 25/drivers/net/wan/wanxl.c~wanxl-build-fix	Mon Sep 22 12:18:36 2003
+++ 25-akpm/drivers/net/wan/wanxl.c	Mon Sep 22 12:21:30 2003
@@ -125,7 +125,8 @@ static inline dma_addr_t pci_map_single_
 	dma_addr_t addr = pci_map_single(pdev, ptr, size, direction);
 	if (addr + size > 0x100000000LL)
 		printk(KERN_CRIT "wanXL %s: pci_map_single() returned memory"
-		       " at 0x%X!\n", card_name(pdev), addr);
+			" at 0x%LX!\n",
+			card_name(pdev), (unsigned long long)addr);
 	return addr;
 }
 
@@ -180,8 +181,7 @@ static inline void wanxl_cable_intr(port
 static inline void wanxl_tx_intr(port_t *port)
 {
 	while (1) {
-                desc_t *desc;
-		desc = &get_status(port)->tx_descs[port->tx_in];
+                desc_t *desc = &get_status(port)->tx_descs[port->tx_in];
 		struct sk_buff *skb = port->tx_skbs[port->tx_in];
 
 		switch (desc->stat) {
@@ -290,12 +290,13 @@ static irqreturn_t wanxl_intr(int irq, v
 
 static int wanxl_xmit(struct sk_buff *skb, struct net_device *dev)
 {
+	desc_t *desc;
 	hdlc_device *hdlc = dev_to_hdlc(dev);
         port_t *port = hdlc_to_port(hdlc);
 
         spin_lock(&port->lock);
 
-	desc_t *desc = &get_status(port)->tx_descs[port->tx_out];
+	desc = &get_status(port)->tx_descs[port->tx_out];
         if (desc->stat != PACKET_EMPTY) {
                 /* should never happen - previous xmit should stop queue */
 #ifdef DEBUG_PKT

_


  reply	other threads:[~2003-09-22 19:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-22  8:35 2.6.0-test5-mm4 Andrew Morton
2003-09-22 11:49 ` 2.6.0-test5-mm4: BeFS compile error Adrian Bunk
2003-09-22 17:57   ` Will Dyson
2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda
2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 13:48   ` 2.6.0-test5-mm4 viro
2003-09-22 14:29     ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 14:30   ` 2.6.0-test5-mm4 Florian Schanda
2003-09-22 14:36   ` 2.6.0-test5-mm4 Zilvinas Valinskas
2003-09-22 13:49     ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 13:54       ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 18:55     ` 2.6.0-test5-mm4 Andrew Morton
2003-09-22 21:27       ` 2.6.0-test5-mm4 Peter Osterlund
2003-09-22 21:45         ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-25  0:13           ` 2.6.0-test5-mm4 Peter Osterlund
2003-09-25 12:43             ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-22 21:44       ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-22 19:10 ` 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95 Adrian Bunk
2003-09-22 19:22   ` Andrew Morton [this message]
2003-09-22 22:42   ` Krzysztof Halasa
2003-09-22 22:41     ` Andrew Morton
2003-09-23 13:24       ` Krzysztof Halasa
2003-09-24  9:18 ` 2.6.0-test5-mm4 boot crash Helge Hafting
2003-09-24  9:57   ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030922122215.4f7da13e.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®