From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] softirq_pending()
Date: Tue, 23 Sep 2003 20:06:21 +0200 [thread overview]
Message-ID: <20030923180621.GA18794@lst.de> (raw)
In-Reply-To: <20030923105841.27809d11.davem@redhat.com>
On Tue, Sep 23, 2003 at 10:58:41AM -0700, David S. Miller wrote:
> The problem is that, on some of the platforms that don't ignore
> the argument, the code generation is much better.
>
> GCC doesn't consider smp_processor_id() like some const local
> variable, so multiple invocations are assumed to return different
> values because in many cases 'current_thread_info()' is obscured.
>
> Your patch is going to make a lot of new code get generated on
> x86 for example, so I don't think it should be applied even though
> my own platforms are not effected by this issue.
Okay, thanks forthe explanation. I don't think it matters in this
case because there's exactly one case where we pass an variable into
softirq_pending() instead of a direct, uncached smp_processor_id() -
and that is in arch/cris/ which is UP only.
I'll try to remember the hint so I know what do to this pops up
the next time, though :)
next prev parent reply other threads:[~2003-09-23 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-23 14:48 Christoph Hellwig
2003-09-23 17:58 ` David S. Miller
2003-09-23 18:06 ` Christoph Hellwig [this message]
2003-09-23 18:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923180621.GA18794@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®