From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262434AbTI0MS5 (ORCPT ); Sat, 27 Sep 2003 08:18:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262440AbTI0MS4 (ORCPT ); Sat, 27 Sep 2003 08:18:56 -0400 Received: from pub234.cambridge.redhat.com ([213.86.99.234]:31494 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S262434AbTI0MSy (ORCPT ); Sat, 27 Sep 2003 08:18:54 -0400 Date: Sat, 27 Sep 2003 13:18:53 +0100 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Christoph Hellwig , Linux Kernel Development Subject: Re: [PATCH] helper for device list traversal Message-ID: <20030927131853.A22669@infradead.org> Mail-Followup-To: Christoph Hellwig , Geert Uytterhoeven , Linux Kernel Development References: <20030927123933.A21629@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from geert@linux-m68k.org on Sat, Sep 27, 2003 at 02:15:56PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 27, 2003 at 02:15:56PM +0200, Geert Uytterhoeven wrote: > The A2091 and GVP-II drivers want to traverse the list of SCSI host adapters in > their interrupt handler, to find their Scsi_Host instances and check whether > the (shared) interrupt was meant for one of them. > > An alternative would be to register the interrupt handler multiple times and > use the Scsi_Host instance pointer as the interrupt handler data pointer. Yes, they should do that. > For 53c7xx it's a bit more complex, I don't know anything about its internals. The occurance in #if 0 code should probably use scsi_lookup_host. process_issue_queue needs to be rewritten to be per-host.