From: Pavel Machek <pavel@ucw.cz>
To: torvalds@transmeta.com,
kernel list <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@osdl.org>
Subject: [pm] Make software resume be called at resume
Date: Mon, 29 Sep 2003 00:24:05 +0200 [thread overview]
Message-ID: <20030928222404.GA227@elf.ucw.cz> (raw)
Hi!
This adds neccessary initcall() so that machine really does resume,
and adds gpl, and makes sure we do not do random bit flips on non-PSE
machine. Please apply,
Pavel
[Yes, software_suspend needs to return int and do some error
handling. But not today, and this is better than random bit flips.]
PS: echo -n mem > /sys/power/state works here (good!), but echo 3 >
/proc/acpi/sleep fails to even put machine to sleep.
--- clean/kernel/power/swsusp.c 2003-09-28 22:06:45.000000000 +0200
+++ linux/kernel/power/swsusp.c 2003-09-29 00:19:37.000000000 +0200
@@ -5,7 +5,10 @@
* machine suspend feature using pretty near only high-level routines
*
* Copyright (C) 1998-2001 Gabor Kuti <seasons@fornax.hu>
- * Copyright (C) 1998,2001,2002 Pavel Machek <pavel@suse.cz>
+ * Copyright (C) 1998,2001-2003 Pavel Machek <pavel@suse.cz>
+ * Copyright (C) 2003 Patrick Mochel <mochel@osdl.org>
+ *
+ * This file is released under the GPLv2.
*
* I'd like to thank the following people for their work:
*
@@ -681,7 +678,8 @@
static void do_software_suspend(void)
{
- arch_prepare_suspend();
+ if (arch_prepare_suspend())
+ panic("Architecture failed to prepare\n");
if (pm_prepare_console())
printk( "%sCan't allocate a console... proceeding\n", name_suspend);
if (!prepare_suspend_processes()) {
@@ -1031,12 +1029,18 @@
return error;
}
-/*
- * Called from init kernel_thread.
- * We check if we have an image and if so we try to resume
+/**
+ * software_resume - Resume from a saved image.
+ *
+ * Called as a late_initcall (so all devices are discovered and
+ * initialized), we call swsusp to see if we have a saved image or not.
+ * If so, we quiesce devices, the restore the saved image. We will
+ * return above (in pm_suspend_disk() ) if everything goes well.
+ * Otherwise, we fail gracefully and return to the normally
+ * scheduled program.
+ *
*/
-
-void software_resume(void)
+static void software_resume(void)
{
if (num_online_cpus() > 1) {
printk(KERN_WARNING "Software Suspend has malfunctioning SMP support. Disabled :(\n");
@@ -1075,6 +1079,8 @@
return;
}
+late_initcall(software_resume);
+
static int __init resume_setup(char *str)
{
if (resume_status == NORESUME)
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next reply other threads:[~2003-09-28 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-28 22:24 Pavel Machek [this message]
2003-09-29 16:57 ` Patrick Mochel
2003-09-29 19:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030928222404.GA227@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®