mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Valdis.Kletnieks@vt.edu
Cc: Muli Ben-Yehuda <mulix@mulix.org>, Andrew Morton <akpm@osdl.org>,
	Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] document optimizing macro for translating PROT_ to VM_ bits
Date: Mon, 29 Sep 2003 18:11:13 +0100	[thread overview]
Message-ID: <20030929171113.GD21798@mail.jlokier.co.uk> (raw)
In-Reply-To: <200309291551.h8TFpZtH028192@turing-police.cc.vt.edu>

Valdis.Kletnieks@vt.edu wrote:
> Is this supposed to return the bitmask bit2, or (x & bit2)?  If the former,
> then your code is right.  If the latter,  (x & bit1) ? (x & bit2) : 0

The former.

> I'm totally failing to see why the original did the bit1 == bit2 compare,
> so maybe mhyself and Jamie are both missing some subtlety?

"bit1 == bit2" was an optimisation.  It made the machine code smaller,
without changing the result.

-- Jamie

  reply	other threads:[~2003-09-29 17:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-29  9:06 Muli Ben-Yehuda
2003-09-29 15:34 ` Jamie Lokier
2003-09-29 15:51   ` Valdis.Kletnieks
2003-09-29 17:11     ` Jamie Lokier [this message]
2003-09-29 17:25     ` Maciej Zenczykowski
2003-09-30  2:15       ` Miles Bader
2003-09-30  7:10   ` Muli Ben-Yehuda
2003-09-30  7:34     ` Miles Bader
2003-09-30  7:41       ` Muli Ben-Yehuda
2003-09-30  7:59         ` Miles Bader
2003-09-30  9:24           ` Muli Ben-Yehuda
2003-09-30 10:00             ` Miles Bader
2003-09-30 10:06               ` Miles Bader
2003-10-02 11:37               ` Muli Ben-Yehuda
2003-09-30 10:35             ` Thomas Schlichter
2003-09-30  8:02   ` Frédéric St-Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030929171113.GD21798@mail.jlokier.co.uk \
    --to=jamie@shareable.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mulix@mulix.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®