From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Valdis.Kletnieks@vt.edu
Cc: Dave Jones <davej@redhat.com>, Matthew Wilcox <willy@debian.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CONFIG_* In Comments Considered Harmful
Date: Wed, 1 Oct 2003 16:42:23 +0200 [thread overview]
Message-ID: <20031001144223.GJ31698@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <200310011429.h91ETtcG009923@turing-police.cc.vt.edu>
On Wed, 1 October 2003 10:29:55 -0400, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 01 Oct 2003 15:19:52 BST, Dave Jones said:
>
> > Maybe it should be taught to parse comments? There are zillions of
> > #endif /* CONFIG_FOO */
> > braces in the tree. Why is this one special ?
>
> I think it's because it looked like:
>
> #ifdef CONFIG_FOO
> ....
> #endif /* CONFIG_FOO or CONFIG_BAR */
>
> and it concluded there was a dependency on BAR.
Or rather like this:
#ifdef CONFIG_FOO
...
#endif /* CONFIG_FO */
Problem is that we humans correct the type before it even reaches our
conciousness. Machines don't do that yet.
Jörn
--
The strong give up and move away, while the weak give up and stay.
-- unknown
next prev parent reply other threads:[~2003-10-01 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 13:26 Matthew Wilcox
2003-10-01 14:19 ` Dave Jones
2003-10-01 14:29 ` Valdis.Kletnieks
2003-10-01 14:42 ` Jörn Engel [this message]
2003-10-01 14:49 ` Matthew Wilcox
2003-10-01 14:41 ` Muli Ben-Yehuda
2003-10-01 14:39 ` Jörn Engel
[not found] ` <20031001145206.GH29313@actcom.co.il>
2003-10-01 15:10 ` Jörn Engel
2003-10-01 20:15 ` Muli Ben-Yehuda
2003-10-01 20:27 ` Linus Torvalds
2003-10-01 14:58 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001144223.GJ31698@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®