mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Roland McGrath <roland@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix vsyscall page in core dumps
Date: Fri, 3 Oct 2003 02:12:51 -0700	[thread overview]
Message-ID: <20031003021251.627dd922.akpm@osdl.org> (raw)
In-Reply-To: <200310030156.h931uZhL015129@magilla.sf.frob.com>

Roland McGrath <roland@redhat.com> wrote:
>
> My change to core dumps that was included with the vsyscall DSO
>  implementation had a bug (braino on my part).  Core dumps don't include the
>  full page of the vsyscall DSO, and so don't accurately represent the whole
>  memory image of the process.  This patch fixes it.  I have tested it on
>  x86, but not tested the same change to 32-bit core dumps on AMD64 (haven't
>  even compiled on AMD64).
> 
>  I've also included the corresponding change for the IA64 code that was
>  copied blindly from the x86 vsyscall implementation, which looks like more
>  change than it is since I preserved the formatting of the copied code
>  instead of arbitrarily diddling it along with the trivial symbol name
>  changes.

How does one test it?

> I haven't compiled or tested on ia64.

I have.  GATE_BASE is undefined.  Replacing it with GATE_ADDR makes it
build OK, but that's all I can say.


      reply	other threads:[~2003-10-03  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-03  1:56 Roland McGrath
2003-10-03  9:12 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031003021251.627dd922.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®