From: Andrew Morton <akpm@osdl.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org, cherry@osdl.org
Subject: Re: [PATCH] applicom: fix LEAK, unwind on errors;
Date: Fri, 3 Oct 2003 16:55:01 -0700 [thread overview]
Message-ID: <20031003165501.4c7edd59.akpm@osdl.org> (raw)
In-Reply-To: <20031003162532.62130e39.rddunlap@osdl.org>
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> -#warning "LEAK"
> - RamIO = ioremap(mem, LEN_RAM_IO * MAX_ISA_BOARD);
> + maxRamIO = ioremap(mem, LEN_RAM_IO * MAX_ISA_BOARD);
>
> - if (!RamIO)
> + if (!maxRamIO)
> printk(KERN_INFO "ac.o: Failed to ioremap ISA memory space at 0x%lx\n", mem);
It seems that this driver is just testing to see if it can ioremap the
whole region before going through and mapping each board.
If we want to keep this sanity check then the iounmap should come
immediately after the ioremap, or it should just be removed.
Probably the latter: if the individual ioremaps work then they've worked,
haven't they?
next prev parent reply other threads:[~2003-10-03 23:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-03 22:46 IA32 - 269 New warnings (gcc 3.2.2) John Cherry
2003-10-03 23:25 ` [PATCH] applicom: fix LEAK, unwind on errors; Randy.Dunlap
2003-10-03 23:55 ` Andrew Morton [this message]
2003-10-03 23:39 ` IA32 - 269 New warnings (gcc 3.2.2) John Cherry
2003-10-10 3:04 [PATCH] applicom: fix LEAK, unwind on errors; Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031003165501.4c7edd59.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=cherry@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®