mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ioe-lkml@rameria.de>
To: "Grover, Andrew" <andrew.grover@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: down_timeout
Date: Sat, 4 Oct 2003 09:53:43 +0200	[thread overview]
Message-ID: <200310040953.43024.ioe-lkml@rameria.de> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A84702C93004@orsmsx401.jf.intel.com>

Hi Andrew,

On Friday 03 October 2003 20:03, Grover, Andrew wrote:
> > From: linux-kernel-owner@vger.kernel.org
> > [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of
> > Matthew Wilcox
> > It's still not great because it doesn't preserve ordering.
> > down_timeout()
> > would be a much better primitive.  We have down_interruptible() which
> > could be used for this purpose.  Something like (completely
> > uncompiled):
>
> Yeah we proposed this 2 years ago and someone (don't remember who) shot
> us down.

It was me.

Reason: 
	I misunderstood your suggestion down_timeout() as "down and hold
	a semaphore until timeout" instead of "try until timeout to get
	the semaphore". I suggested using waitqueues for this.

But now that I understand, what you really want, I agree that this is
very useful and also agree that the kernel should provide it.

I don't think that I prevented it from being accepted, but my opinion
about it might had have the wrong influence.

I'm really sorry, that this simple communication problem caused you,
the ACPI development and users such a big pain.

PS: And I still think that semaphores with a maximum hold time are a bad
    idea in the linux kernel. But this is just *my* opinion ;-)

Regards

Ingo Oeser



  reply	other threads:[~2003-10-04  7:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-03 18:03 down_timeout Grover, Andrew
2003-10-04  7:53 ` Ingo Oeser [this message]
     [not found] <3F7D6DA1.9070801@namesys.com>
2003-10-03 14:25 ` down_timeout Matthew Wilcox
2003-10-03 20:36   ` down_timeout Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2001-04-26 16:27 down_timeout Moore, Robert
2001-04-25 23:21 down_timeout Grover, Andrew
2001-04-25 23:49 ` down_timeout Ingo Oeser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200310040953.43024.ioe-lkml@rameria.de \
    --to=ioe-lkml@rameria.de \
    --cc=andrew.grover@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®