From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (2/7): common i/o layer.
Date: Mon, 6 Oct 2003 15:01:23 +0100 [thread overview]
Message-ID: <20031006150123.A17816@infradead.org> (raw)
In-Reply-To: <20031006092448.GC1786@mschwid3.boeblingen.de.ibm.com>; from schwidefsky@de.ibm.com on Mon, Oct 06, 2003 at 11:24:48AM +0200
On Mon, Oct 06, 2003 at 11:24:48AM +0200, Martin Schwidefsky wrote:
> +static void
> +chp_release(struct device *dev)
> +{
> +}
> +
> /*
> * Entries for chpids on the system bus.
> * This replaces /proc/chpids.
> @@ -863,8 +869,10 @@
> /* fill in status, etc. */
> chp->id = chpid;
> chp->state = status;
> - chp->dev.parent = &css_bus_device;
> -
> + chp->dev = (struct device) {
> + .parent = &css_bus_device,
> + .release = chp_release,
> + };
Eek. How is the dummy release function supposed to help
anything? you must free the object in ->release. Also
the assignment is horrible as hell.
Dito for the following patches.
next prev parent reply other threads:[~2003-10-06 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 9:24 Martin Schwidefsky
2003-10-06 14:01 ` Christoph Hellwig [this message]
2003-10-06 14:40 Martin Schwidefsky
2003-10-06 14:44 ` Christoph Hellwig
2003-10-06 14:49 Martin Schwidefsky
2003-10-06 14:55 ` Christoph Hellwig
2003-10-06 15:37 Martin Schwidefsky
2003-10-06 15:46 ` viro
2003-10-06 15:59 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031006150123.A17816@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome