From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI serial fix
Date: Wed, 8 Oct 2003 12:41:41 -0600 [thread overview]
Message-ID: <200310081241.41825.bjorn.helgaas@hp.com> (raw)
Here's another little fix for ACPI serial discovery in 2.6.
Intel 870 firmware reports an extra zero-length IO port range, which
is bogus, as far as I can tell. Ignore it.
===== drivers/serial/8250_acpi.c 1.4 vs edited =====
--- 1.4/drivers/serial/8250_acpi.c Mon Oct 6 15:57:02 2003
+++ edited/drivers/serial/8250_acpi.c Wed Oct 8 12:36:31 2003
@@ -38,6 +38,11 @@
static acpi_status acpi_serial_port(struct serial_struct *req,
struct acpi_resource_io *io)
{
+ if (!io->range_length) {
+ printk(KERN_ERR "%s: zero-length IO port range?\n", __FUNCTION__);
+ return AE_ERROR;
+ }
+
req->port = io->min_base_address;
req->io_type = SERIAL_IO_PORT;
return AE_OK;
next reply other threads:[~2003-10-08 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 18:41 Bjorn Helgaas [this message]
2003-10-08 20:25 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310081241.41825.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®