From: Pavel Machek <pavel@suse.cz>
To: "David S. Miller" <davem@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleanup of compat_ioctl functions
Date: Wed, 8 Oct 2003 23:35:44 +0200 [thread overview]
Message-ID: <20031008213544.GB1238@elf.ucw.cz> (raw)
In-Reply-To: <20031008140207.666a62c9.davem@redhat.com>
Hi!
> > Well, in the light of 'strictly bug fixes only', it was probably too
> > much search&replace already. I guess I'll have to prepare a new patch
> > that just fixes the bugs in the current s390 compat_ioctl code and not
> > use fs/compat_ioctl.c in 2.6.0.
>
> That doesn't make any sense, the fact that fs/compat_ioctl.c isn't
> using the proper compat user pointer accessor macros is a bug,
> so just fix that.
>
> It defeats the whole purpose of this compat layer if people still
> need to duplicate the code in some cases.
Agreed, your changes are trivial and reviewed extremely easily. That
is not going to break anything. Okay, I guess no need to change __u16
into anything...
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-10-08 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 16:09 Arnd Bergmann
2003-10-08 19:29 ` Pavel Machek
2003-10-08 20:26 ` Arnd Bergmann
2003-10-08 21:02 ` David S. Miller
2003-10-08 21:35 ` Pavel Machek [this message]
2003-10-08 22:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008213544.GB1238@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=arnd@arndb.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®