Re: -test7: /sys/power/disk not reading right data?

[Pavel Machek <pavel@ucw.cz>]

Hi!

> I'm seeing this on -test7 (tainted:pavel, but I did not touch this
> area).

Reproduced on -test7-bk, vanilla.

I really do not think that 2 separate files (disk, state) are good
idea. It bitten me, again. I did echo -n platform > disk, echo -n disk
> state. Unfortunately kernel somehow decided that platform suspend is
not supported, but honoured second request. Result is crash, of
course. This error would be avoided if I said echo -n swsusp > state
(or similar), because unrecognized/unsupported request would be simply
not done.

What advantages does disk/ state separation have? I believe that echo
swsusp > state (or echo s4bios > state or echo disk-firmware > state)
is the right interface, and that we want to do echo "s4bios" >
on_battery_low or similar interface. (echo "mem" > on_battery_low
makes sense, too, toshiba notebooks do that for example).

> root@amd:~# echo -n platform > /sys/power/disk
> root@amd:~# dmesg | tail -1
> PM: suspend-to-disk mode set to 'platform'
> root@amd:~# cat /sys/power/disk
> firmware
> root@amd:~#

								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]