From: Andrew Morton <akpm@osdl.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] invalidate_mmap_range() misses remap_file_pages()-affected targets
Date: Sun, 12 Oct 2003 04:56:44 -0700 [thread overview]
Message-ID: <20031012045644.0dce8f6b.akpm@osdl.org> (raw)
In-Reply-To: <20031012103436.GC765@holomorphy.com>
William Lee Irwin III <wli@holomorphy.com> wrote:
>
> It would seem that mincore() shares a similar issue on account of its
> algorithm
Yes, I think it makes sense to fix mincore(). I don't fully understand the
reasoning behind the three cases though:
+ if (pte_file(*pte))
+ present = mincore_linear_page(vma, pte_to_pgoff(*pte));
+ else if (!(vma->vm_flags | (VM_READ|VM_WRITE|VM_MAYREAD|VM_MAYWRITE)))
+ present = pte_present(*pte);
+ else
+ present = mincore_linear_page(vma, pgoff);
Could you explain the logic behind each of these? Perhaps with permanent
comments?
next prev parent reply other threads:[~2003-10-12 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 8:48 William Lee Irwin III
2003-10-12 10:34 ` William Lee Irwin III
2003-10-12 11:56 ` Andrew Morton [this message]
2003-10-12 19:51 ` William Lee Irwin III
2003-10-13 0:59 ` William Lee Irwin III
2003-10-12 11:53 ` Andrew Morton
2003-10-12 19:38 ` William Lee Irwin III
2003-10-12 20:28 ` Rik van Riel
2003-10-12 21:19 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031012045644.0dce8f6b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®