From: Andrew Morton <akpm@osdl.org>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org,
Cciss-discuss@lists.sourceforge.net
Subject: Re: [PATCH] release_region in cciss block driver
Date: Sun, 12 Oct 2003 17:15:13 -0700 [thread overview]
Message-ID: <20031012171513.7bac1562.akpm@osdl.org> (raw)
In-Reply-To: <3F81744E.3080105@terra.com.br>
Felipe W Damasio <felipewd@terra.com.br> wrote:
>
> --- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
> +++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
> @@ -2185,6 +2185,7 @@
> schedule_timeout(HZ / 10); /* wait 100ms */
> }
> if (scratchpad != CCISS_FIRMWARE_READY) {
> + release_io_mem(c);
> printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
> return -1;
> }
It seems to me that the driver is already performing this function
in the caller.
static int __devinit cciss_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
...
if (cciss_pci_init(hba[i], pdev) != 0)
goto clean1;
...
clean1:
release_io_mem(hba[i]);
free_hba(i);
return(-1);
}
prev parent reply other threads:[~2003-10-13 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 13:28 Felipe W Damasio
2003-10-06 13:42 ` Jens Axboe
2003-10-06 13:55 ` Felipe W Damasio
2003-10-13 0:15 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031012171513.7bac1562.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Cciss-discuss@lists.sourceforge.net \
--cc=axboe@suse.de \
--cc=felipewd@terra.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®