From: Andrew Morton <akpm@osdl.org>
To: Felipe W Damasio <felipewd@terra.com.br>
Cc: support@comtrol.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] release_region in RocketPort char driver
Date: Sun, 12 Oct 2003 17:31:17 -0700 [thread overview]
Message-ID: <20031012173117.35bd221c.akpm@osdl.org> (raw)
In-Reply-To: <3F81769B.1060508@terra.com.br>
Felipe W Damasio <felipewd@terra.com.br> wrote:
>
> --- linux-2.6.0-test6/drivers/char/rocket.c.orig 2003-10-06 10:57:29.000000000 -0300
> +++ linux-2.6.0-test6/drivers/char/rocket.c 2003-10-06 11:00:29.000000000 -0300
> @@ -2468,6 +2468,7 @@
> if (retval < 0) {
> printk(KERN_INFO "Couldn't install tty RocketPort driver (error %d)\n", -retval);
> put_tty_driver(rocket_driver);
> + release_region(controller, 4);
> return -1;
> }
a) If variable `controller' is zero then we never allocated this region,
so we should not free it.
b) There is an error exit path further on which also needs to release
this region (if controller != 0).
next prev parent reply other threads:[~2003-10-13 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 14:05 Felipe W Damasio
2003-10-13 0:31 ` Andrew Morton [this message]
2003-10-14 13:44 ` Felipe W Damasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031012173117.35bd221c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=felipewd@terra.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=support@comtrol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®