From: Andrew Morton <akpm@osdl.org>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.6] No swapping on memory backed swapfiles
Date: Mon, 13 Oct 2003 02:24:41 -0700 [thread overview]
Message-ID: <20031013022441.79c800b6.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.53.0310130502440.28426@montezuma.fsmlabs.com>
Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
>
> On Mon, 13 Oct 2003, Andrew Morton wrote:
>
> > Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
> > >
> > > + bdi = mapping->backing_dev_info;
> > > + if (bdi->memory_backed)
> > > + goto bad_swap;
> > > +
> >
> > I guess that makes sense, although someone might want to swap onto a
> > ramdisk-backed file just for some testing purpose.
> >
> > Why not simply test for a null ->readpage()?
>
> That was my initial intention, but then i wondered why someone would be
> swapping to a memory backed filesystem in the first place. Also things
> like ramfs have ->readpage().
A non-memory-backed fs may still have a NULL ->readpage though (ncpfs?).
I do think it best to just test for ->readpage, and give the user the extra
rope.
next prev parent reply other threads:[~2003-10-13 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-13 7:57 Zwane Mwaikambo
2003-10-13 8:11 ` Andrew Morton
2003-10-13 8:32 ` John Bradford
2003-10-13 9:15 ` Zwane Mwaikambo
2003-10-16 21:31 ` bill davidsen
2003-10-13 9:05 ` Zwane Mwaikambo
2003-10-13 9:24 ` Andrew Morton [this message]
2003-10-13 9:34 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031013022441.79c800b6.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®