From: Kirill Korotaev <kk@sw.ru>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Invalidate_inodes can be very slow
Date: Mon, 13 Oct 2003 14:46:25 +0400 [thread overview]
Message-ID: <200310131446.25921.kk@sw.ru> (raw)
In-Reply-To: <20031013095347.GF16158@holomorphy.com>
> Untested brute-force forward port to 2.6.0-test7-bk4. No idea if the
> locking is correct or if list movement is done in all needed places.
First of all, thanks for forward port. I think this patch is quite usefull
for both 2.4 and 2.6 kernels, but I can't check it on all kernels myself.
comments:
1. why have you replaced list_del with list_del_init in my patch?
It's not required.
2. locks are ok, as for i_list, i_hash lists.
3. Missed
+list_add(&inode->i_sb_list, &sb->s_inodes);
in get_new_inode_fast() function. Please add it.
I looked through, everything else looks ok.
[your patch]
Kirill
next prev parent reply other threads:[~2003-10-13 10:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-13 9:18 Kirill Korotaev
2003-10-13 9:53 ` William Lee Irwin III
2003-10-13 10:46 ` Kirill Korotaev [this message]
2003-10-13 11:06 ` William Lee Irwin III
2003-10-13 11:08 ` Andrew Morton
2003-10-13 11:19 ` William Lee Irwin III
2003-10-13 11:45 ` Kirill Korotaev
2003-10-13 11:54 ` William Lee Irwin III
2003-10-13 12:02 ` Kirill Korotaev
2003-10-13 12:11 ` William Lee Irwin III
2003-10-13 12:21 ` Kirill Korotaev
2003-10-13 12:29 ` Nikita Danilov
2003-10-13 13:08 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310131446.25921.kk@sw.ru \
--to=kk@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®