mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] More i2c driver fixes for 2.6.0-test7
Date: Wed, 15 Oct 2003 21:13:00 +0200	[thread overview]
Message-ID: <20031015191300.GA11752@mars.ravnborg.org> (raw)
In-Reply-To: <10662411472283@kroah.com>

On Wed, Oct 15, 2003 at 11:05:47AM -0700, Greg KH wrote:
> -device_create_file(&client->dev, &dev_attr_in_max##offset);
> +device_create_file(&client->dev, &dev_attr_in_max##offset); \
> +} while (0);
              ^
Did you really want to have that ';' there?
It is harmless in current usage, but it may be confusing.

	Sam

      parent reply	other threads:[~2003-10-15 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-15 18:04 [BK PATCH] " Greg KH
2003-10-15 18:05 ` [PATCH] " Greg KH
2003-10-15 18:05   ` Greg KH
2003-10-15 18:05     ` Greg KH
2003-10-15 19:14       ` Sam Ravnborg
2003-10-15 19:13     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031015191300.GA11752@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®