From: Christoph Hellwig <hch@infradead.org>
To: Colin Ngam <cngam@sgi.com>
Cc: Jes Sorensen <jes@trained-monkey.org>,
Patrick Gefre <pfg@sgi.com>,
linux-kernel@vger.kernel.org, davidm@napali.hpl.hp.com,
jbarnes@sgi.com
Subject: Re: [PATCH] Altix I/O code cleanup
Date: Fri, 17 Oct 2003 09:11:26 +0100 [thread overview]
Message-ID: <20031017091125.A22492@infradead.org> (raw)
In-Reply-To: <3F8ECA11.C4281A8C@sgi.com>; from cngam@sgi.com on Thu, Oct 16, 2003 at 11:40:49AM -0500
On Thu, Oct 16, 2003 at 11:40:49AM -0500, Colin Ngam wrote:
> > to panic() on a failed kmalloc because the data structure is required
> > for a core service, then doing ASSERT_ALWAYS isn't that unreasonable.
>
> ASSERT_ALWAYS is used for many other cases other than just for
> testing NULL Pointers. Whether you call ASSERT_ALWAYS or
> call panic with a message or just allow it to oops, a descriptive panic
> message can save some time.
Of course - but that's not that point. You have to handle an out of
memory situtation propery because it may happen all the time - you
should not panic at all. The ASSERT_ALWAYS just confuses automatic
checker tools that help to find such conditions.
next prev parent reply other threads:[~2003-10-17 8:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-10 21:49 Patrick Gefre
2003-10-10 21:51 ` Jesse Barnes
2003-10-10 22:50 ` David Mosberger
2003-10-10 23:51 ` Jesse Barnes
2003-10-13 8:58 ` Christoph Hellwig
2003-10-13 10:55 ` Andrew Morton
2003-10-13 14:06 ` Christoph Hellwig
2003-10-13 8:56 ` Christoph Hellwig
2003-10-15 8:07 ` Jes Sorensen
2003-10-15 12:55 ` Christoph Hellwig
2003-10-16 13:08 ` Jes Sorensen
2003-10-16 16:40 ` Colin Ngam
2003-10-17 8:11 ` Christoph Hellwig [this message]
2003-10-17 13:36 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031017091125.A22492@infradead.org \
--to=hch@infradead.org \
--cc=cngam@sgi.com \
--cc=davidm@napali.hpl.hp.com \
--cc=jbarnes@sgi.com \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®