From: William Lee Irwin III <wli@holomorphy.com>
To: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: highmem-zone memory hotremoval test patch
Date: Fri, 17 Oct 2003 02:35:26 -0700 [thread overview]
Message-ID: <20031017093526.GF25291@holomorphy.com> (raw)
In-Reply-To: <20031017082835.713167007A@sv1.valinux.co.jp>
On Fri, Oct 17, 2003 at 05:28:35PM +0900, IWAMOTO Toshihiro wrote:
> diff -dpur linux-2.6.0-test1/fs/proc/kcore.c linux-2.6.0-test1-mh/fs/proc/kcore.c
> --- linux-2.6.0-test1/fs/proc/kcore.c Mon Jul 14 12:34:39 2003
> +++ linux-2.6.0-test1-mh/fs/proc/kcore.c Thu Jul 31 16:01:37 2003
> @@ -450,7 +450,7 @@ static ssize_t read_kcore(struct file *f
> }
> kfree(elf_buf);
> } else {
> - if (kern_addr_valid(start)) {
> + if (1 /*kern_addr_valid(start)*/) {
> unsigned long n;
>
> n = copy_to_user(buffer, (char *)start, tsz);
kern_addr_valid() has been bogus garbage for a while, and smbfs and
ncpfs are swiss cheese. IMHO unless some arch gets its act together and
acquires a legitimate use for it, pgdat->valid_addr_bitmap and
kern_addr_valid() should be removed. And probably d_validate(), too.
-- wli
prev parent reply other threads:[~2003-10-17 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-17 8:28 IWAMOTO Toshihiro
2003-10-17 9:35 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031017093526.GF25291@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=iwamoto@valinux.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome