From: Jens Axboe <axboe@suse.de>
To: William Lee Irwin III <wli@holomorphy.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: I/O errors in -test7-mm1 tree on ia64
Date: Fri, 17 Oct 2003 12:12:19 +0200 [thread overview]
Message-ID: <20031017101219.GD1128@suse.de> (raw)
In-Reply-To: <20031016204649.GA1778@sgi.com>
On Thu, Oct 16 2003, Jesse Barnes wrote:
> On Thu, Oct 16, 2003 at 12:49:34PM -0700, William Lee Irwin III wrote:
> > On Thu, Oct 16, 2003 at 11:55:05AM -0700, Jesse Barnes wrote:
> > > I don't see this when using Linus' BK tree as of a few minutes ago, and
> > > the only changes I've made are adding the kgdb.h for ia64 and adding in
> > > the Altix console driver. Any ideas? I'll try reverting some patches
> > > and looking around a bit more.
> >
> > Well, the first thing to try is backing out invalidate_inodes-speedup.patch
>
> That didn't seem to help. Got the same errors.
--- fs/xfs/pagebuf/page_buf.c 2003-10-17 12:11:30.000000000 +0200
+++ fs/xfs/pagebuf/page_buf.c~ 2003-10-17 12:11:19.000000000 +0200
@@ -1406,10 +1406,8 @@
int cmd = WRITE;
if (pb->pb_flags & PBF_READ)
cmd = READ;
-#if 0
else if (pb->pb_flags & PBF_FLUSH)
cmd = WRITESYNC;
-#endif
submit_bio(cmd, bio);
if (size)
goto next_chunk;
it was a mistake to enable barriers unconditionally on XFS when it has
no fallback logic. If you apply the above on test7-mm1, it should work
fine for you.
--
Jens Axboe
next prev parent reply other threads:[~2003-10-17 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-16 18:55 Jesse Barnes
2003-10-16 19:49 ` William Lee Irwin III
2003-10-16 20:46 ` Jesse Barnes
2003-10-17 10:12 ` Jens Axboe [this message]
2003-10-17 10:13 ` Jens Axboe
2003-10-17 22:15 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031017101219.GD1128@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome