Re: [RFT][PATCH] fix ServerWorks PIO auto-tuning

[Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>]

On Friday 17 of October 2003 11:51, Torben Mathiasen wrote:
> On Thu, Oct 16 2003, Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> >
> > I wonder if this patch fixes problems (reported back in 2.4.21 days)
> > with CSB5 IDE and Compaq Proliant machines.  Please test it if you can.
>
> Hi Bart,
>
> Funny you should send this as I was just looking at it. The good news is
> that it works!. We're not seeing any failed commands during boot anymore. I
> tested it on both 2.4.23-pre7 and 2.6.0-test7.

Great!

> Also, the previous problem we had where Linux would enable DMA on a device
> (system) not supporting it has also been fixed now that we look at the
> dma_stat bits to determine whether the BIOS indicated DMA. We're currently

Can I assume that "biostimings" option is no longer needed for ServerWorks?

If so I will remove it because it is dangerous on many chipsets.
Even if some chipset needs it in the future it should be reimplemented
in specific chipset driver, not in generic IDE code.

> making sure that all of our servers does proper BIOS IDE setup to make
> things work as expected.
>
> Thanks for the patch, please include it.

Sure.

thanks,
--bartlomiej