From: Christoph Hellwig <hch@infradead.org>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linux-kernel@vger.kernel.org, Brard Roudier <groudier@free.fr>
Subject: Re: [patch][1/3] qlogic: use scsi_host_alloc instead scsi_register
Date: Fri, 17 Oct 2003 12:57:57 +0100 [thread overview]
Message-ID: <20031017125757.A26699@infradead.org> (raw)
In-Reply-To: <20031016015213.GA1765@cathedrallabs.org>; from aris@cathedrallabs.org on Wed, Oct 15, 2003 at 11:52:13PM -0200
On Wed, Oct 15, 2003 at 11:52:13PM -0200, Aristeu Sergio Rozanski Filho wrote:
> +++ linux/drivers/scsi/qlogicfas.c 2003-10-15 23:41:28.000000000 -0200
> @@ -671,7 +671,7 @@
> if (qlirq >= 0 && !request_irq(qlirq, do_ql_ihandl, 0, "qlogicfas", NULL))
> host->can_queue = 1;
> #endif
> - hreg = scsi_register(host, 0); /* no host data */
> + hreg = scsi_host_alloc(host, 0); /* no host data */
> if (!hreg)
> goto err_release_mem;
> hreg->io_port = qbase;
> @@ -679,6 +679,7 @@
> hreg->dma_channel = -1;
> if (qlirq != -1)
> hreg->irq = qlirq;
> + INIT_LIST_HEAD(&hreg->sht_legacy_list);
This is not good - please use scsi_register for the !PCMCIA case
instead of opencoding it - sht_legacy_list should be completely opaque
to drivers. Maybe once the current freeze is over we can convert
qlogic.c to a proper new-style driver and merge qlogic_cs into it
instead of having two copies of the same codebase compiled with slightly
different cpp symbols.
prev parent reply other threads:[~2003-10-17 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-16 1:52 Aristeu Sergio Rozanski Filho
2003-10-16 21:34 ` Mike Christie
2003-10-17 11:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031017125757.A26699@infradead.org \
--to=hch@infradead.org \
--cc=aris@cathedrallabs.org \
--cc=groudier@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®