mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Shantanu Goel <sgoel01@yahoo.com>
Cc: linux-kernel@vger.kernel.org,
	Marcelo Tosatti <marcelo@conectiva.com.br>,
	Andrea Arcangeli <andrea@suse.de>
Subject: Re: [PATCH] 2.4.23-pre7 vmscan.c typo
Date: Sun, 19 Oct 2003 22:00:05 -0700	[thread overview]
Message-ID: <20031019220005.129e5358.akpm@osdl.org> (raw)
In-Reply-To: <20031020014025.42111.qmail@web12812.mail.yahoo.com>

Shantanu Goel <sgoel01@yahoo.com> wrote:
>
> The following appears to be a typo in mm/vmscan.c
> 

It sure is.  Scary.

--- a/mm/vmscan.c	2003-10-19 21:36:26.000000000 -0400
+++ a/mm/vmscan.c	2003-10-19 21:37:17.000000000 -0400
@@ -596,7 +596,7 @@
 			continue;
 		}
 
-		nr_pages--;
+		ratio--;
 
 		del_page_from_active_list(page);
 		add_page_to_inactive_list(page);



I note that `ratio' here is the number of pages which we try to deactivate
rather than the number of pages which we scan.  Is this intentional?


  reply	other threads:[~2003-10-20  4:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-20  1:40 Shantanu Goel
2003-10-20  5:00 ` Andrew Morton [this message]
2003-10-20  5:32   ` Andrea Arcangeli
2003-10-20 10:54     ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031019220005.129e5358.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=sgoel01@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®