From: Andrew Morton <akpm@osdl.org>
To: Jacek Kawa <jfk@zeus.polsl.gliwice.pl>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
netfilter-devel@lists.netfilter.org
Subject: Re: 2.6.0-test6, connntrack/sis900/net (?) Badness in local_bh_enable at kernel/softirq.c:119
Date: Mon, 20 Oct 2003 16:14:37 -0700 [thread overview]
Message-ID: <20031020161437.6708e994.akpm@osdl.org> (raw)
In-Reply-To: <20031020222306.GB32167@finwe.eu.org>
Jacek Kawa <jfk@zeus.polsl.gliwice.pl> wrote:
>
> I found it in logs (2.6.0-test6). It happened little while after
> I had reloaded dhcpd configuration.
>
> I'm not sure if it's related to NIC or ip-conntrack, but as both
> are mentioned...
>
> System information below.
>
> eth0: Media Link Off
> NETDEV WATCHDOG: eth0: transmit timed out
> eth0: Transmit timeout, status 00000004 00000000
> Badness in local_bh_enable at kernel/softirq.c:119
> Call Trace:
> [local_bh_enable+137/144] local_bh_enable+0x89/0x90
> [_end+130859013/1069963240] ip_ct_find_proto+0x3d/0x60 [ip_conntrack]
> [_end+130860013/1069963240] destroy_conntrack+0x15/0x110 [ip_conntrack]
> [sock_wfree+73/80] sock_wfree+0x49/0x50
> [__kfree_skb+143/272] __kfree_skb+0x8f/0x110
> [_end+130608961/1069963240] sis900_tx_timeout+0x99/0x150 [sis900]
> [dev_watchdog+0/208] dev_watchdog+0x0/0xd0
> [dev_watchdog+191/208] dev_watchdog+0xbf/0xd0
This should fix it up.
diff -puN drivers/net/sis900.c~sis900-tx_timeout-fix drivers/net/sis900.c
--- 25/drivers/net/sis900.c~sis900-tx_timeout-fix Mon Oct 20 16:10:04 2003
+++ 25-akpm/drivers/net/sis900.c Mon Oct 20 16:10:11 2003
@@ -1438,7 +1438,7 @@ static void sis900_tx_timeout(struct net
pci_unmap_single(sis_priv->pci_dev,
sis_priv->tx_ring[i].bufptr, skb->len,
PCI_DMA_TODEVICE);
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
sis_priv->tx_skbuff[i] = 0;
sis_priv->tx_ring[i].cmdsts = 0;
sis_priv->tx_ring[i].bufptr = 0;
_
next prev parent reply other threads:[~2003-10-20 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-20 22:23 Jacek Kawa
2003-10-20 23:14 ` Andrew Morton [this message]
2003-10-20 23:48 ` Jacek Kawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031020161437.6708e994.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jfk@zeus.polsl.gliwice.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®