From: Ben Collins <bcollins@debian.org>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: marcelo.tosatti@cyclades.com.br,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, James Goodwin <jamesg@filanet.com>
Subject: Re: patch for 2.4.22 sbp2 hang when loaded with devices already connected
Date: Mon, 20 Oct 2003 21:06:10 -0400 [thread overview]
Message-ID: <20031021010610.GB866@phunnypharm.org> (raw)
In-Reply-To: <orbrsba0eg.fsf@free.redhat.lsd.ic.unicamp.br>
On Mon, Oct 20, 2003 at 10:40:23PM -0200, Alexandre Oliva wrote:
> We were free()ing a packet before sbp2_agent_reset() had a chance to
> wake up on its semaphore, which would often cause sbp2 to hang in
> `initializing' state if it was loaded when firewire devices were
> already connected to the host. Details of the symptoms at
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=103821
>
> This patch fixes it. I guess Ben likes it because he sent me a very
> similar patch to test just as I was finishing testing this one :-)
>
> Thanks, Ben, for helping me figure out what was going on!
Please let me send the patch to Marcelo. I have to get this into our
repo, and merge things around back to Marcelo, else it makes things
harder later.
Thanks for following through with the debug to track this down.
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
next prev parent reply other threads:[~2003-10-21 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ord6csra7h.fsf@free.redhat.lsd.ic.unicamp.br>
2003-10-21 0:40 ` Alexandre Oliva
2003-10-21 1:06 ` Ben Collins [this message]
2003-10-21 1:37 ` Alexandre Oliva
2003-10-21 1:46 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031021010610.GB866@phunnypharm.org \
--to=bcollins@debian.org \
--cc=aoliva@redhat.com \
--cc=jamesg@filanet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=marcelo.tosatti@cyclades.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®