mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Poetzl <herbert@13thfloor.at>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, Alex Lyashkov <shadow@itt.net.ru>
Subject: Linux 2.4 quota (accounting?) bug ...
Date: Sat, 25 Oct 2003 18:26:40 +0200	[thread overview]
Message-ID: <20031025162640.GA24020@DUK2.13thfloor.at> (raw)


Hi Honza!

a friend of mine, made me aware of the following
imbalance, which looks like a minor accounting bug 
to me, but might be a quota bug ...

fs/dquot.c : 394 vfs_quota_sync()
-----------------------------------------------------
                /* Get reference to quota so it won't be invalidated. get_dquot_ref()
                 * is enough since if dquot is locked/modified it can't be
                 * on the free list */

> 		get_dquot_ref(dquot);
 		if (dquot->dq_flags & DQ_LOCKED)
 			wait_on_dquot(dquot);
 		if (dquot_dirty(dquot))
 			sb->dq_op->sync_dquot(dquot);
>		dqput(dquot);
 		goto restart;
 	}


best,
Herbert



             reply	other threads:[~2003-10-25 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-25 16:26 Herbert Poetzl [this message]
2003-10-25 16:31 ` Jan Kara
2003-10-25 17:42   ` Herbert Poetzl
2003-10-28 23:40     ` Jan Kara
2003-11-05 20:36     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031025162640.GA24020@DUK2.13thfloor.at \
    --to=herbert@13thfloor.at \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shadow@itt.net.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®