From: "P. Christeas" <p_christ@hol.gr>
To: Andrew Morton <akpm@osdl.org>
Cc: gibbs@scsiguy.com, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.0-test9, aic7xxx [passed]
Date: Mon, 27 Oct 2003 23:18:53 +0300 [thread overview]
Message-ID: <200310272218.53181.p_christ@hol.gr> (raw)
In-Reply-To: <20031026191641.497132ec.akpm@osdl.org>
> "P. Christeas" <p_christ@hol.gr> wrote:
> > One more, (as reported a few weeks ago):
> > rmmod aic7xxx
> > will fail, as this module uses some wrong locks. This will also block
> > sleeping (tested w. ACPI) if the module is there.
> > IMHO this module is crucial to many systems.
>
> The rmmod works OK for me, in the sense that the module is removed, the
> kernel doesn't crash and the module can be reloaded.
>
> But yes, there are several locking problems in there:
>
> - ahc_free() now sleeps, deep down in the kobject layer somewhere (it
> calls /sbin/hotplug).
>
> This is a likely fix for that:
>
You 're right. I just tested -test9 and it can fully rmmod the module. I
recall that in -test5, 7 the module wouldn't be cleaned, but now it's OK. The
warnings (enabled by the .config option) still appear (several of them). I am
on a UP, however and don't know if a SMP system would happen to have trouble.
I'll also give your patch a try.
Thanks.
prev parent reply other threads:[~2003-10-27 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-26 18:51 Linux 2.6.0-test9 P. Christeas
2003-10-27 3:16 ` Andrew Morton
2003-10-27 20:18 ` P. Christeas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310272218.53181.p_christ@hol.gr \
--to=p_christ@hol.gr \
--cc=akpm@osdl.org \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome