From: viro@parcelfarce.linux.theplanet.co.uk
To: Linus Torvalds <torvalds@osdl.org>
Cc: Konstantin Boldyshev <konst@linuxassembly.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
marcelo.tosatti@cyclades.com
Subject: Re: minix fs corruption fix for 2.4
Date: Mon, 3 Nov 2003 17:19:25 +0000 [thread overview]
Message-ID: <20031103171925.GH7665@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0311030851430.20373-100000@home.osdl.org>
On Mon, Nov 03, 2003 at 08:55:42AM -0800, Linus Torvalds wrote:
> I'd also prefer to do the test the other way around: test for CHRDEV and
> BLKDEV in inode.c the same way the other functions do. Something like the
> appended..
>
> Al, can you verify? I think this crept in when you did the block lookup
> cleanups. I also worry whether anybody else got the bug?
>
> Linus
Hmm... I would rather check for regular|directory|symlink explicitly -
note that FIFO and socket can have junk in i_data.
Looks like that fsckup had happened only in fs/minix - fs/sysv/itree.c
does it right.
next prev parent reply other threads:[~2003-11-03 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-03 13:21 Konstantin Boldyshev
2003-11-03 16:55 ` Linus Torvalds
2003-11-03 17:19 ` viro [this message]
2003-11-03 17:50 ` Linus Torvalds
2003-11-04 6:30 ` Konstantin Boldyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031103171925.GH7665@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=konst@linuxassembly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®