On Mon, Nov 03, 2003 at 12:06:47PM -0800, Andrew Morton wrote: > OK. I think. Net driver suspend handlers in general seem a bit racy wrt > interrupt activity as well as SMP. Maybe I'm missing something. Looking at the logs I just discovered the following line buried in the middle of all that Bad: scheduling while atomic during resume: eth0: Abnormal interrupt, status 0x03008200 This seems to happen with all the patches I sent you, but then the network card is working correctly, it seems a leftover handled correctly on the first interrupt.. > > I think also the 8139too driver has the same locking problem in > > rtl8139_suspend, do you want a patch ? > > Wouldn't hurt, thanks. It's one way to wake Jeff up ;) Attached you find a patch that just moves up the lock release before the call to pci_set_power_state. (and Jeff is CCed) > 8139too just does netif_device_detach(), whereas your sis900 patch does > netif_stop_queue() and then netif_device_detach(). > > I don't know which is right, really. 8139too will end up with a > non-stopped queue if __LINK_STATE_PRESENT is clear. The sis900 approach is > certainly safe enough, but it'd be nice to know what netif_device_detach() > is trying to do there. I tried to comment out the stop_queue call, and suspending with the network cable unplugged. The card keeps working on resume, as I was expecting. Perhaps we could keep only the stop_queue call and still remain on the safe side, certainly doing two times the same call is dumb. With this setup (only stop_queue) I did not get any Abnormal interrupt message, but I don't know if they are related. So in the end you get two patches, the 8139too and the sis900 with no locking and no netif_device_detach. Both are available at http://teg.homeunix.org/kernel_patches.html -- ------------------------------ Daniele Venzano Web: http://teg.homeunix.org