From: Andrew Morton <akpm@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: neilb@cse.unsw.edu.au, bwindle@fint.org, Linux-kernel@vger.kernel.org
Subject: Re: slab corruption in test9 (NFS related?)
Date: Sun, 9 Nov 2003 20:51:12 -0800 [thread overview]
Message-ID: <20031109205112.358b0692.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0311092007451.3002-100000@home.osdl.org>
Linus Torvalds <torvalds@osdl.org> wrote:
>
>
> On Mon, 10 Nov 2003, Neil Brown wrote:
> >
> > An extra dput was introduced in nfsd_rename 20 months ago....
> >
> > time to remove it.
>
> Oh, you stand-up comedian you.
>
> I'm just wondering how the hell this hasn't bit us seriously until now?
> What's up?
Me too.
If the dentry was on the dentry_unused list then it would get a whacky
refcount and we would simply leak it.
It is only in the very rare case that the dentry gets freed up between the
two dput()s that the slab debugging will trip.
So probably, we've been leaking dentries as a result of rename activity by
NFS clients, but nobody noticed.
next prev parent reply other threads:[~2003-11-10 4:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-09 23:16 Burton Windle
2003-11-10 3:04 ` Andrew Morton
2003-11-10 3:05 ` Neil Brown
2003-11-10 4:09 ` Linus Torvalds
2003-11-10 4:23 ` Joshua Kwan
2003-11-10 4:36 ` Trond Myklebust
2003-11-10 4:42 ` Linus Torvalds
2003-11-10 4:36 ` Neil Brown
2003-11-10 4:45 ` Linus Torvalds
2003-11-10 4:51 ` Andrew Morton [this message]
2003-11-10 5:56 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031109205112.358b0692.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=bwindle@fint.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®