From: Matt Mackall <mpm@selenic.com>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: lkcd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
suparna@in.ibm.com
Subject: Re: LKCD Network dump over netpoll patch (2.6.0-test9)
Date: Mon, 10 Nov 2003 18:52:33 -0600 [thread overview]
Message-ID: <20031111005233.GV13246@waste.org> (raw)
In-Reply-To: <20031110140742.GJ1409@in.ibm.com>
On Mon, Nov 10, 2003 at 07:37:42PM +0530, Prasanna S Panchamukhi wrote:
> Hi,
>
Hi.
> + put_unaligned(htonl(reply.nr), (u32 *) (tmp_membuf + 1));
> + put_unaligned(htonl(reply.code), (u32 *) (tmp_membuf + 5));
> + put_unaligned(htonl(reply.info), (u32 *) (tmp_membuf + 9));
> +
> + memcpy((tmp_membuf + HEADER_LEN), buff + offset, 1024);
> + netpoll_send_udp(np, tmp_membuf, (1024 + HEADER_LEN));
There's quite a few instances of this header business, it could really
stand to be in its own netdump_send(nr, code, info, data) function.
> - dump_ndev->poll_controller(dump_ndev);
> + netpoll_poll(&net_dev->np);
> zap_completion_queue();
...
> +void zap_completion_queue(void);
Instead of this (missing netpoll_, btw), how about we call
zap_completion_queue inside of netpoll_poll?
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2003-11-11 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-10 14:07 Prasanna S Panchamukhi
2003-11-11 0:52 ` Matt Mackall [this message]
2003-11-14 4:57 ` Prasanna S Panchamukhi
2003-11-14 5:22 ` Prasanna S Panchamukhi
-- strict thread matches above, loose matches on Subject: below --
2003-11-10 13:54 Prasanna S Panchamukhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031111005233.GV13246@waste.org \
--to=mpm@selenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcd-devel@lists.sourceforge.net \
--cc=prasanna@in.ibm.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome