mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Nigel Cunningham <ncunningham@clear.net.nz>,
	Patrick Mochel <mochel@osdl.org>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: swsusp patch..
Date: Wed, 12 Nov 2003 00:53:54 +0100	[thread overview]
Message-ID: <20031111235354.GB543@elf.ucw.cz> (raw)
In-Reply-To: <1068059491.4179.14.camel@laptop-linux>

Hi!

> Hi. Here's the first reply I sent to Patrick.

[Sorry for long delay; cc-ing patrick and l-k so that this discussion
is archived somewhere; hope you don't mind.]

> Secondly, regarding the freezer hooks, they're the result of a long
> period of working on the problem. You see, the freezer in your tree at
> the moment isn't robust. If you try to initiate a suspend at the wrong
> time, particularly where there's heavy I/O, it will sometimes deadlock
> (particularly in journalling filesystem code if I remember correctly -
> it's been a while since I had the problem) or at least take a long time
> (try initiating a suspend during dd if=/dev/zero of=testfile bs=4096
> count=100000). Another problem is that you will be writing dirty data to
> swap. This freezer implementation overcomes those issues. It
> provides a

Well, writing dirty data to swap does not look like too bad
problem. If it simplifies things, I'm happy with dirty data in swap.

> of others. (Remember that in my version, I use activelist & inactivelist
> pages for the atomic copy of the rest of the data as well as any free
> memory, thereby overcoming the half-of-memory limitation). If
> someone

...introducing another "half-of-kernelmemory" limitation. [Did you see
people hitting half-of-memory problem in practice?].

How is it possible that copying into activelist & inactivelist helps?
If memorymanagment is working correctly then those lists should be
empty...

I know you are not freeing memory agresively.. But perhaps you have
exactly same "half-of-memory" problem as 2.6.0-test9 implementation
has?

> comes up with a better way to do this, I'll be more than happy to
> listen, as always. I've spent a long time looking at the issue though,
> and doubt that will happen. I'm sure the macros could be made to look
> nicer or perhaps written in assembly to improve speed, but I can't see

No assembly, please. Nicer macros would be welcome, through. No macros
would be best ;-).

Deadlocks... any user process stopped with sigstop should not block
anything in-kernel, right? That means that perhaps we need to be more
clever about kernel threads, but we should be able to get away without
hooks in paths such as "sys_read()". If killall -SIGSTOP can stop the
processes safely without additional hooks, we should be able to do
that, too...

								Pavel

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

           reply	other threads:[~2003-11-11 23:54 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1068059491.4179.14.camel@laptop-linux>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031111235354.GB543@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=ncunningham@clear.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®