Fwd: Re: Badness in atomic_dec_and_test in 2.6.0-test9-mm2

[Bradley Chapman <kakadu_croc@yahoo.com>]

Mr. Morton,

--- Mike Anderson <andmike@us.ibm.com> wrote:
> 
> Greg posted a response the other day to a query from Alan Stern. Here is
> the link 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=106835250124362&w=2
> 
> This should be the same problem that you are hitting.
> 
> A patch was checked into Linus's tree on 2003-11-07 by Greg that made a
> couple line change to class.c.
> 
> Here is the patch in case you need to stay on mm2.
> 
> -andmike
> --
> Michael Anderson
> andmike@us.ibm.com
> 
> --- 1.41/drivers/base/class.c	Fri Aug 29 14:18:26 2003
> +++ 1.42/drivers/base/class.c	Fri Nov  7 06:48:28 2003
> @@ -255,6 +255,7 @@
>  
>  void class_device_initialize(struct class_device *class_dev)
>  {
> +	kobj_set_kset_s(class_dev, class_obj_subsys);
>  	kobject_init(&class_dev->kobj);
>  	INIT_LIST_HEAD(&class_dev->node);
>  }
> @@ -277,7 +278,6 @@
>  
>  	/* first, register with generic layer. */
>  	kobject_set_name(&class_dev->kobj, class_dev->class_id);
> -	kobj_set_kset_s(class_dev, class_obj_subsys);
>  	if (parent)
>  		class_dev->kobj.parent = &parent->subsys.kset.kobj;
> 

This patch fixes the badness-on-unplug error that I reported to linux-kernel.

Brad

=====
Brad Chapman

Permanent e-mail: kakadu_croc@yahoo.com

__________________________________
Do you Yahoo!?
Protect your identity with Yahoo! Mail AddressGuard
http://antispam.yahoo.com/whatsnewfree