mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Harald Welte <laforge@netfilter.org>
Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: seq_file and exporting dynamically allocated data
Date: Sat, 15 Nov 2003 20:36:07 +0000	[thread overview]
Message-ID: <20031115203607.GP24159@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20031115173310.GA4786@obroa-skai.de.gnumonks.org>

On Sat, Nov 15, 2003 at 06:33:10PM +0100, Harald Welte wrote:
> On Sat, Nov 15, 2003 at 05:18:44PM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Sat, Nov 15, 2003 at 10:38:33AM +0100, Harald Welte wrote:
> > > that doesn't help.  As I am aware, the seq_file structure is only
> > > allocated in the seq_open() call.  How does seq_open() know which
> > > private data (i.e. hash table) to associate with struct file?
> > 
> > Why should seq_open() know that?  Its caller does and it can set the damn
> > thing to whatever it wants.
> 
> So who is the caller? it's the ->open() member of struct
> file_operations.  and struct file_operations doesn't have some private
> member where I could hide my pointer before saving it to
> seq_file.private in seq_open().

If arguments of ->open() were not enough to find your data, how the hell would
current code manage to find it?

You've got inode; you've got (if that's on procfs) proc_dir_entry - from
inode; you've got dentry (from struct file *).  If that's not enough to
find your data, what is?

Which files do you have in mind?

  parent reply	other threads:[~2003-11-15 20:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-14 20:42 Harald Welte
2003-11-14 21:01 ` Tigran Aivazian
2003-11-15  9:38   ` Harald Welte
2003-11-15 17:18     ` viro
2003-11-15 17:33       ` Harald Welte
2003-11-15 19:49         ` Tigran Aivazian
2003-11-15 20:14           ` viro
2003-11-15 20:41             ` Tigran Aivazian
2003-11-15 21:30               ` viro
2003-11-15 20:50             ` Tigran Aivazian
2003-11-15 21:33               ` viro
2003-11-15 21:54                 ` Tigran Aivazian
2003-11-16  7:27                   ` Tigran Aivazian
2003-11-17  5:48                     ` viro
2003-11-17  8:21                       ` Tigran Aivazian
2003-11-17  8:30                         ` William Lee Irwin III
2003-11-17  8:38                           ` Tigran Aivazian
2003-11-17  8:48                             ` William Lee Irwin III
2003-11-17  9:03                               ` William Lee Irwin III
2003-11-17  9:42                                 ` Tigran Aivazian
2003-11-17  9:50                                   ` William Lee Irwin III
2003-11-17  9:55                                   ` viro
2003-11-17 10:08                                     ` Tigran Aivazian
2003-11-17 10:35                                       ` viro
2003-11-17  9:48                                 ` viro
2003-11-16 20:45               ` Harald Welte
2003-11-15 20:36         ` viro [this message]
2003-11-16 20:42           ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031115203607.GP24159@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=laforge@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tigran@aivazian.fsnet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome