mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>, paulkf@microgate.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.4 patch] fixup after synclink update
Date: Tue, 18 Nov 2003 20:07:05 +0100	[thread overview]
Message-ID: <20031118190704.GQ326@fs.tum.de> (raw)

2.4.23-rc contains a synclink update that contains the following change:

<--  snip  -->

 static struct pci_driver synclink_pci_driver = {
        name:           "synclink",
        id_table:       synclink_pci_tbl,
        probe:          synclink_init_one,
-       remove:         __devexit_p(synclink_remove_one),
+       remove:         synclink_remove_one,
 };

<--  snip  -->


This change causes the following compile error when compiling the driver 
statically into a kernel without hotplug support:

<--  snip  -->

...
        --end-group \
        -o vmlinux
local symbol 0: discarded in section `.text.exit' from drivers/char/char.o
make: *** [vmlinux] Error 1

<--  snip  -->


The following patch reverts this bogus change:

--- linux-2.4.23-rc1-full-nohotplug/drivers/char/synclink.c.old	2003-11-18 18:30:06.000000000 +0100
+++ linux-2.4.23-rc1-full-nohotplug/drivers/char/synclink.c	2003-11-18 18:31:14.000000000 +0100
@@ -945,7 +945,7 @@
 	name:		"synclink",
 	id_table:	synclink_pci_tbl,
 	probe:		synclink_init_one,
-	remove:		synclink_remove_one,
+	remove:		__devexit_p(synclink_remove_one),
 };
 
 static struct tty_driver serial_driver, callout_driver;



Please apply for 2.4.23-rc2.


TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


                 reply	other threads:[~2003-11-18 19:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031118190704.GQ326@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=paulkf@microgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®